OAPE-817: Add automated PR review comment handler using Claude Code CLI#63
OAPE-817: Add automated PR review comment handler using Claude Code CLI#63neha037 wants to merge 4 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: neha037 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
- Add resolved-thread filtering via GraphQL (skip already-resolved threads) - Add pure-acknowledgment filtering (skip LGTM, Thanks, +1 etc.) - Add PR commit messages to Claude's prompt for better context - Batch all pushes into single push after all threads processed - Add post-push SHA verification - Fix fork-based PRs: push to head repo (fork), not upstream - Add rebase before push with force-with-lease fallback - Add "reject invalid requests" guidance to SKILL.md Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2d47cb4 to
e019678
Compare
- C2: Added check_review_summary() function to check_replied.py that correctly checks for bot replies after a review submission (using REST API timestamps instead of mismatched GraphQL node IDs). Updated build_threads.py type_map to use the new review_summary type.
- C1: Kept -p flag (it works correctly for CI — tools still execute), updated docs to accurately describe print mode with tool use.
- C3: Removed all --max-turns 20 references from docs (flag doesn't exist in Claude CLI).
Important fixes:
- I1: Aligned SKILL.md exit code 2 handling with build_threads.py — both now treat it as "proceed with caution".
- I2: Fixed null-unsafe comment["user"]["login"] at two locations in check_replied.py to use .get() chains.
- I3: Replaced --force-with-lease fallback with safe failure — logs warning and exits instead of risking overwrite of concurrent commits.
- I4: Fork-based PRs now use a separate fork remote for push, keeping origin pointed at upstream so origin/${BASE_BRANCH} diffs still work.
Minor fixes:
- M1: Updated stale docs (push batching, allowed tools list, post-commit guardrails).
- M2: Changed missing python3 from exit 0 to exit 1 (it's a hard requirement).
- M3: Moved local tid out of the while loop body to function scope.
|
@neha037: This pull request references OAPE-817 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
No description provided.